*DELETED*

General discussion for off-topic subjects.
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

[Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 1:21 pm

Maybe you should put a limit on the size of the image in the signature?
Last edited by Sam on Mon Jun 22, 2020 1:21 pm, edited 1 time in total.
Reason: Original post version
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 1:33 pm

Maybe it’s worth making a limit to 256x256?
Last edited by Sam on Mon Jun 22, 2020 1:33 pm, edited 1 time in total.
Reason: Original post version
User avatar
Ayuto
Project Leader
Posts: 2094
Joined: Sat Jul 07, 2012 8:17 am
Location: Germany

Re: [Warning] Signature bug!

Postby Ayuto » Mon Jun 22, 2020 1:36 pm

Changed it, thank you!
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 1:37 pm

No problems
Last edited by Sam on Mon Jun 22, 2020 1:37 pm, edited 1 time in total.
Reason: Original post version
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 1:40 pm

Problem still exists xDDD
Last edited by Sam on Mon Jun 22, 2020 1:40 pm, edited 1 time in total.
Reason: Original post version
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 1:47 pm

Syntax: Select all

.postbody img.postimage {
max-width: 256px;
max-height: 256px;
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}

Hot fix
Last edited by Sam on Mon Jun 22, 2020 1:47 pm, edited 1 time in total.
Reason: Original post version
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 2:00 pm

You set a limit on the picture, but what if the resolution of the picture changes on the remote machine? You did not fix the final bug
Last edited by Sam on Mon Jun 22, 2020 2:00 pm, edited 1 time in total.
Reason: Original post version
Sam
Senior Member
Posts: 100
Joined: Tue Jul 03, 2018 3:00 pm
Location: *DELETED*
Contact:

Re: [Warning] Signature bug!

Postby Sam » Mon Jun 22, 2020 2:09 pm

You do not need to modify the forum logic. It is necessary to put a restriction in the css file itself or class "postimage".
Or better:
1. Replace: <img src="..." class="postimage" alt="Image">
-> To: <img src="..." class="postimage" style="max-width: 256px;max-height: 256px;" alt="Image">
Last edited by Sam on Mon Jun 22, 2020 2:09 pm, edited 1 time in total.
Reason: Original post version
User avatar
Ayuto
Project Leader
Posts: 2094
Joined: Sat Jul 07, 2012 8:17 am
Location: Germany

Re: [Warning] Signature bug!

Postby Ayuto » Wed Jun 24, 2020 10:11 am

I was hoping the admin setting I changed would do the job, but apperently it didn't. I guess I will pass this on to Muerte.
User avatar
La Muerte
Administrator
Posts: 180
Joined: Sun Jul 15, 2012 1:48 pm
Location: Belgium
Contact:

Re: [Warning] Signature bug!

Postby La Muerte » Thu Jul 16, 2020 12:39 pm

does the 256x256 limit not work when people try to set new signatures, or does it only not work for existing signatures?
because in case of the latter, the css suggestion should "resolve" that for the already existing signatures.
User avatar
L'In20Cible
Project Leader
Posts: 1335
Joined: Sat Jul 14, 2012 9:29 pm
Location: Québec

Re: [Warning] Signature bug!

Postby L'In20Cible » Thu Jul 16, 2020 1:21 pm

La Muerte wrote:does the 256x256 limit not work when people try to set new signatures, or does it only not work for existing signatures?
because in case of the latter, the css suggestion should "resolve" that for the already existing signatures.

phpBB only check the size of the images when you attempt to set it into a signature, but he is using a dynamic link so he bypass that check by setting the image size to be lower than the restriction configured and then change the size of the image returned by that same link which is what clients are requesting and displaying. So yeah, a CSS fix would works.

Return to “Whatever”

Who is online

Users browsing this forum: No registered users and 1 guest