Page 1 of 1

[Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:21 pm
by Sam
Maybe you should put a limit on the size of the image in the signature?

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:33 pm
by Sam
Maybe it’s worth making a limit to 256x256?

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:36 pm
by Ayuto
Changed it, thank you!

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:37 pm
by Sam
No problems

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:40 pm
by Sam
Problem still exists xDDD

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 1:47 pm
by Sam

Syntax: Select all

.postbody img.postimage {
max-width: 256px;
max-height: 256px;
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}

Hot fix

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 2:00 pm
by Sam
You set a limit on the picture, but what if the resolution of the picture changes on the remote machine? You did not fix the final bug

Re: [Warning] Signature bug!

Posted: Mon Jun 22, 2020 2:09 pm
by Sam
You do not need to modify the forum logic. It is necessary to put a restriction in the css file itself or class "postimage".
Or better:
1. Replace: <img src="..." class="postimage" alt="Image">
-> To: <img src="..." class="postimage" style="max-width: 256px;max-height: 256px;" alt="Image">

Re: [Warning] Signature bug!

Posted: Wed Jun 24, 2020 10:11 am
by Ayuto
I was hoping the admin setting I changed would do the job, but apperently it didn't. I guess I will pass this on to Muerte.

Re: [Warning] Signature bug!

Posted: Thu Jul 16, 2020 12:39 pm
by La Muerte
does the 256x256 limit not work when people try to set new signatures, or does it only not work for existing signatures?
because in case of the latter, the css suggestion should "resolve" that for the already existing signatures.

Re: [Warning] Signature bug!

Posted: Thu Jul 16, 2020 1:21 pm
by L'In20Cible
La Muerte wrote:does the 256x256 limit not work when people try to set new signatures, or does it only not work for existing signatures?
because in case of the latter, the css suggestion should "resolve" that for the already existing signatures.

phpBB only check the size of the images when you attempt to set it into a signature, but he is using a dynamic link so he bypass that check by setting the image size to be lower than the restriction configured and then change the size of the image returned by that same link which is what clients are requesting and displaying. So yeah, a CSS fix would works.