Quakesounds

Release your plugins here!
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Quakesounds

Postby cssbestrpg » Tue May 26, 2020 3:45 pm

User avatar
Sam
Senior Member
Posts: 167
Joined: Tue Jul 03, 2018 3:00 pm
Location: Russian Federation
Contact:

Re: Quakesounds

Postby Sam » Tue May 26, 2020 3:49 pm

Tip: soundlib -> engines.sound.Sound
It's a trap!
Image
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Tue May 26, 2020 7:31 pm

Nice to see that there are now also some for SP.

High praise

little things I noticed:

Headshot, Teamkill for teamdeathmatch, Multikill ,humiliation, suizide are things that are very interesting but unfortunately missing.

Maybe you still have the desire to add to this.

Greeting Painkiller
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Re: Quakesounds

Postby cssbestrpg » Tue May 26, 2020 7:35 pm

Some point i could add missing sounds

So far now:

Added now humiliation sound when knife kill
Added multikill sound
Added headshot sound
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Wed May 27, 2020 7:28 am

I will test it in the next days on a separate server and let you know.
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Wed May 27, 2020 3:56 pm

Hello mate, a friend tested the plugin and this is the first bug he noticed.

Code: Select all

2020-05-27 10:11:19 - sp   -   MESSAGE   [SP] Successfully loaded plugin 'quakesound'.
2020-05-27 10:14:14 - sp   -   EXCEPTION   
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\events\listener.py", line 92, in fire_game_event
    callback(game_event)
  File "..\addons\source-python\plugins\quakesound\quakesound.py", line 61, in player_death
    if int(args['headshot']):


Code: Select all

2020-05-27 10:15:16 - sp   -   EXCEPTION   
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\events\listener.py", line 92, in fire_game_event
    callback(game_event)
  File "..\addons\source-python\plugins\quakesound\quakesound.py", line 61, in player_death
    if int(args['headshot']):

KeyError: "Key 'headshot' does not exist."
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Re: Quakesounds

Postby cssbestrpg » Wed May 27, 2020 4:29 pm

Can he test now? i made possible fix for headshot
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Thu May 28, 2020 7:47 am

This come now.
User avatar
Ayuto
Project Leader
Posts: 2088
Joined: Sat Jul 07, 2012 8:17 am
Location: Germany

Re: Quakesounds

Postby Ayuto » Thu May 28, 2020 10:38 am

cssbestrpg wrote:Can he test now? i made possible fix for headshot

This won't really fix the issue in HL2DM. It now just uses a default value (0) if the key "headshot" wasn't found (HL2DM doesn't provide a headshot key in the event player_death). You need to check the player's last hitgroup:

Syntax: Select all

from events import Event
from players.entity import Player
from players.constants import HitGroup

@Event('player_death')
def on_player_death(event):
player = Player.from_userid(event['userid'])
if player.last_hitgroup == HitGroup.HEAD:
# Your code...
print('Headshot')
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Re: Quakesounds

Postby cssbestrpg » Thu May 28, 2020 11:01 am

Now updated the code, thanks Ayuto, i didn't know was HL2DM, i did make the code for css orginaly
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Thu May 28, 2020 7:02 pm

Thanks a lot it will be tested again.

It is always nice to have quake sounds for several games and not just for one specific game.

Code: Select all

2020-05-28 14:24:18 - sp   -   MESSAGE   [SP] Loading plugin 'quakesound'...
2020-05-28 14:24:18 - sp   -   WARNING   
[SP] Encountered a Warning:
  File '..\addons\source-python\packages\site-packages\path.py', line 1713: DeprecationWarning
    path is deprecated. Use Path instead.

2020-05-28 14:24:18 - sp   -   MESSAGE   [SP] Successfully loaded plugin 'quakesound'.
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Re: Quakesounds

Postby cssbestrpg » Thu May 28, 2020 7:45 pm

The warning error can ignore, did the all sounds work? specially the headshot one?
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Thu May 28, 2020 10:08 pm

My mate, says no sound plays.
User avatar
L'In20Cible
Project Leader
Posts: 1331
Joined: Sat Jul 14, 2012 9:29 pm
Location: Québec

Re: Quakesounds

Postby L'In20Cible » Thu May 28, 2020 11:25 pm

There is a missing = on this line: ../quakesound.py#L74
cssbestrpg
Junior Member
Posts: 13
Joined: Sun May 17, 2020 7:56 am
Location: Finland

Re: Quakesounds

Postby cssbestrpg » Fri May 29, 2020 8:21 am

Fixed now missing =
User avatar
Ayuto
Project Leader
Posts: 2088
Joined: Sat Jul 07, 2012 8:17 am
Location: Germany

Re: Quakesounds

Postby Ayuto » Fri May 29, 2020 9:35 am

I guess I worked too much with another language lately (I also used the pipe (|) as a comment...) :rolleyes:
User avatar
Painkiller
Senior Member
Posts: 561
Joined: Sun Mar 01, 2015 8:09 am
Location: Germany
Contact:

Re: Quakesounds

Postby Painkiller » Fri May 29, 2020 4:36 pm

Works now.

Return to “Plugin Releases”

Who is online

Users browsing this forum: No registered users and 3 guests