Page 1 of 1

[CSGO] Crash in run_command since update

Posted: Thu May 25, 2017 9:24 am
by existenz
Hey !

Since the Csgo update the Warcraft mod crash every time when a player join the server and spawn.
I have found that the problem is in run_command hook. If i comment the following line the server doesn't crash.

https://github.com/Predz/SP-Warcraft-Mod/blob/master/addons/source-python/plugins/warcraft/calls.py#L118

Date : 2017-05-25 09:24:13.572909
OS : Linux-3.16.0-4-amd64-x86_64-with-debian-8.7
Game : csgo
SP version : 580
Server plugins:
00: Source.Python, (C) 2012-2016, Source.Python Team.
SP plugins:
00: advert
01: admin, 0.1, https://venomz.fr/
02: download
03: map_cycle
04: map_config
05: noblock
06: resetscore, 1.0, https://venomz.fr/
07: showdamage
08: vip
09: warcraft


Sincerly Existenz.

Re: [CSGO] Crash in run_command since update

Posted: Thu May 25, 2017 12:13 pm
by satoon101

Re: [CSGO] Crash in run_command since update

Posted: Thu May 25, 2017 12:17 pm
by existenz
Yes i have a bot too. But i have disable the run_command Hook for the moment and it works fine.

Re: [CSGO] Crash in run_command since update

Posted: Fri May 26, 2017 9:32 am
by existenz
Thanks to Predz.
It's because some offsets has been changed : https://github.com/alliedmodders/source ... 1384611a79

Re: [CSGO] Crash in run_command since update

Posted: Fri May 26, 2017 1:34 pm
by Predz
Not thanks to me, hehe.

Thanks to the sourcemod team for being so quick at updating their data files :P

Re: [CSGO] Crash in run_command since update

Posted: Fri May 26, 2017 2:17 pm
by satoon101
If anyone is willing, please post a pull request. I am not sure when any of us devs will be able to get to this. I know I am super busy for the next several days.

Re: [CSGO] Crash in run_command since update

Posted: Fri May 26, 2017 2:39 pm
by Predz
I will test all of them tonight after I finish work, then I will post a pull request. Unless anyone beats me to it that is what my plan is tonight :)

Re: [CSGO] Crash in run_command since update

Posted: Fri May 26, 2017 5:25 pm
by existenz
I prefer to let Predz do that. I do not want to break his plans :P

Re: [CSGO] Crash in run_command since update

Posted: Sat May 27, 2017 5:50 pm
by iPlayer
Looks like we'll need to update all offsets in https://github.com/Source-Python-Dev-Team/Source.Python/blob/master/addons/source-python/data/source-python/entities/csgo/CBasePlayer.ini.
It seems that those offsets were incremented by 1 (probably Valve has added some virtual in the beginning of the class).

That's not exactly #199. #199 is basically another issue, present only on Windows.

Also,
We don't use some of the signatures/offsets that Sourcemod uses. Also we use some signatures/offsets that Sourcemod doesn't. That means we can't just blindly copy-paste fixed signatures/offsets from AM commits - we will have to update ALL of our signatures/offsets, but we can use AM commits as a reference.

Re: [CSGO] Crash in run_command since update

Posted: Sat May 27, 2017 10:56 pm
by iPlayer
Topic was moved to General Discussion

Re: [CSGO] Crash in run_command since update

Posted: Mon May 29, 2017 4:59 pm
by decompile
No updates so far, Windows CS:GO doesnt load for me, and Linux just crashes the server.

Re: [CSGO] Crash in run_command since update

Posted: Tue May 30, 2017 8:58 am
by existenz
On your linux server, you use run_command ?

On linux i have test 4 offsets from https://github.com/Source-Python-Dev-Te ... Player.ini

You can increase by one bump_weapon, drop_weapon, give_named_item, run_command. It works for me.
I have also modify pre_think and post_think but not tested.

Re: [CSGO] Crash in run_command since update

Posted: Tue May 30, 2017 7:33 pm
by Ayuto
I just updated the data. Sorry for the delay.
https://github.com/Source-Python-Dev-Te ... 81e9fcbf28